Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: we need a label for icon only badge components #3325

Open
mfranzke opened this issue Oct 18, 2024 · 1 comment
Open

refactor: we need a label for icon only badge components #3325

mfranzke opened this issue Oct 18, 2024 · 1 comment
Labels
👂accessibility Accessibility issues/improvements 🍄🆙improvement New feature or request

Comments

@mfranzke
Copy link
Member

In case that a badge component only includes an icon, we would still need a label for that one (this is not just about badges that are placed in corners).
@mfranzke mfranzke added 🍄🆙improvement New feature or request 👂accessibility Accessibility issues/improvements labels Oct 18, 2024
@mfranzke mfranzke added this to the v0.6.0 milestone Oct 18, 2024
@mfranzke mfranzke removed this from the v0.6.0 milestone Oct 27, 2024
@nmerget
Copy link
Member

nmerget commented Oct 29, 2024

You don't need a label you would pass the text as children like we have it here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
👂accessibility Accessibility issues/improvements 🍄🆙improvement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mfranzke @nmerget