Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove django-councilmatic as a dependency. #361

Closed
1 of 3 tasks
fgregg opened this issue Sep 11, 2023 · 3 comments · Fixed by #392
Closed
1 of 3 tasks

remove django-councilmatic as a dependency. #361

fgregg opened this issue Sep 11, 2023 · 3 comments · Fixed by #392

Comments

@fgregg
Copy link
Member

fgregg commented Sep 11, 2023

experience has taught us that the pattern where we have base templates, views, and models in one repo, which we we subtype and override in this project creates a lot of friction without benefits.

not only does that produce confusing indirection, changes to django-councilmatic have to be made slowly and carefully to not impinge on la-metro

i propose that we remove django-councilmatic as a dependency for chi-councilmatic.

here's what would be needed

  • localize all the templates
  • localize all the views
  • localize all the models

we've already localized all the templates. and it won't be too hard to localize the views as we have largely duplicated all of them anyway.

localizing the models will be the most challenging piece as we need to provide hooks so that when chicago-council-scrapers run it will update the right models.

we could do that by making the chi-councilmatic models an installable app as python-opencivicdata does.

@fgregg
Copy link
Member Author

fgregg commented Sep 11, 2023

if we made the python-opencivicdata models more fit for purpose for a web app, this would make things a lot simpler.

opencivicdata/python-opencivicdata#150

@derekeder
Copy link
Member

+1

lets do it!

@fgregg
Copy link
Member Author

fgregg commented Sep 12, 2023

removing views here: #368

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants