Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Lint/UnusedSelf and Lint/UnusedPseudoMethod #556

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

nobodywasishere
Copy link
Contributor

Closes #543

@Sija Sija added the rule label Jan 29, 2025
@Sija Sija added this to the 1.7.0 milestone Jan 29, 2025
@Sija Sija requested review from Sija and veelenga January 29, 2025 23:48
@nobodywasishere nobodywasishere force-pushed the nobody/unused-pseudo-or-self branch from e737603 to cec18f4 Compare February 18, 2025 08:01
@nobodywasishere nobodywasishere marked this pull request as ready for review February 18, 2025 08:08
src/ameba/rule/lint/unused_pseudo_method.cr Outdated Show resolved Hide resolved
src/ameba/rule/lint/unused_self.cr Outdated Show resolved Hide resolved
src/ameba/rule/lint/unused_self.cr Outdated Show resolved Hide resolved
@nobodywasishere nobodywasishere force-pushed the nobody/unused-pseudo-or-self branch from cec18f4 to e26961a Compare February 18, 2025 18:49
Comment on lines +89 to +94
it "fails if prefix not is unused" do
expect_issue subject, <<-CRYSTAL
!true
# ^^^ error: Pseudo-method is not used
CRYSTAL
end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't this confusing? It says "Pseudo-method is not used" but there are not any methods/calls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Lint/UnusedSelf and Lint/UnusedPseudoMethod
3 participants