Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't leak dependencies into later tasks (eg. aot, uberjar) #37

Open
Deraen opened this issue Jan 6, 2016 · 1 comment
Open

Don't leak dependencies into later tasks (eg. aot, uberjar) #37

Deraen opened this issue Jan 6, 2016 · 1 comment
Labels
Milestone

Comments

@Deraen
Copy link
Collaborator

Deraen commented Jan 6, 2016

Currently boot-cljs-test adds dependency to doo directly using set-env!. This causes side-effects in case if cljs-test is being run as part of package task, the doo dependency would be added to resulting uberjar.

Simple workaround would be to add the dependency with :scope "test" but even then if would case side-effect on classpath.

Proper way would be to use pods to isolate this dependency.

@crisptrutski
Copy link
Owner

Remember having then removing pods from my first attempt, but can't recall why. Probably was just doing it wrong 😄

@crisptrutski crisptrutski added this to the 0.3.0 milestone Jan 6, 2016
@crisptrutski crisptrutski changed the title Use pods Don't leak dependencies into later tasks (eg. aot, uberjar) Jan 6, 2016
@crisptrutski crisptrutski modified the milestones: 0.3.1, 0.3.0 Nov 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants