Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build script does not work with local dependencies #7

Open
abelmokadem opened this issue Jun 17, 2021 · 1 comment
Open

Build script does not work with local dependencies #7

abelmokadem opened this issue Jun 17, 2021 · 1 comment

Comments

@abelmokadem
Copy link

abelmokadem commented Jun 17, 2021

Put something like this in your pipfile:

bootstrapperlib = {path = '/foo/bar/my-lib', editable = true}

Run build script

Traceback (most recent call last):
  File "_CI/scripts/build.py", line 71, in <module>
    raise SystemExit(not build())
  File "_CI/scripts/build.py", line 53, in build
    save_requirements()
  File "/Users/abelmokadem/Projects/gitlab/bootstrappercli/_CI/library/library.py", line 380, in save_requirements
    top_level_packages, top_level_dev_packages = get_top_level_dependencies()
  File "/Users/abelmokadem/Projects/gitlab/bootstrappercli/_CI/library/library.py", line 335, in get_top_level_dependencies
    packages = [Package(name_, version_) for name_, version_ in pip_packages]
  File "/Users/abelmokadem/Projects/gitlab/bootstrappercli/_CI/library/library.py", line 335, in <listcomp>
    packages = [Package(name_, version_) for name_, version_ in pip_packages]
  File "/Users/abelmokadem/Projects/gitlab/bootstrappercli/_CI/library/library.py", line 80, in __init__
    self.comparator, self.version = self._decompose_full_version(full_version)
  File "/Users/abelmokadem/Projects/gitlab/bootstrappercli/_CI/library/library.py", line 94, in _decompose_full_version
    if full_version.startswith(operator):
AttributeError: 'dict' object has no attribute 'startswith'
@costastf
Copy link
Owner

I don't think it's worth fixing this, it would be better to update the template to not use requirements.txt since that is not needed any more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants