chore(telemetry): show total item count in view search filtering and add usage events #1044
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Two main things done in this PR:
getChildren()
to then show in the view message (and send with telemetry)Any additional details or context that should be provided?
I was on the fence about the "total count" idea since we can expand the full tree all the time, so it's more of a "total count so far based on what items have been expanded".
I also have some nits about the mixed resource types all being counted together, so you don't get a more elaborate count like
Showing 13 of 50 topics and 4 of 35 schema subjects for "searchstring"
. We could start counting them individually, but that may end up being more noisy than what's necessary for now.Pull request checklist
Please check if your PR fulfills the following (if applicable):
Tests
Other
.vsix
file?