Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(telemetry): show total item count in view search filtering and add usage events #1044

Draft
wants to merge 3 commits into
base: djs/produce-usage-events
Choose a base branch
from

Conversation

shouples
Copy link
Contributor

@shouples shouples commented Feb 7, 2025

Summary of Changes

Two main things done in this PR:

  • Added a new "view search action" event for telemetry
  • Added basic counting of (unfiltered) items returned from getChildren() to then show in the view message (and send with telemetry)
image

Any additional details or context that should be provided?

I was on the fence about the "total count" idea since we can expand the full tree all the time, so it's more of a "total count so far based on what items have been expanded".

I also have some nits about the mixed resource types all being counted together, so you don't get a more elaborate count like Showing 13 of 50 topics and 4 of 35 schema subjects for "searchstring". We could start counting them individually, but that may end up being more noisy than what's necessary for now.

Pull request checklist

Please check if your PR fulfills the following (if applicable):

Tests
  • Added new
  • Updated existing
  • Deleted existing
Other
  • All new disposables (event listeners, views, channels, etc.) collected as for eventual cleanup?
  • Does anything in this PR need to be mentioned in the user-facing CHANGELOG or README?
  • Have you validated this change locally by packaging and installing the extension .vsix file?
    gulp clicktest

@shouples shouples linked an issue Feb 7, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add telemetry for view-search actions
1 participant