-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to WebPack 5 #1953
Comments
@calebeby I don't know your availability or how this would prioritize compared to other tasks, but if you had some bandwidth, this would be great to get your eyes on. |
@spaceninja I would guess this is closer to a 5-10 than a 2. I would rather switch to vite if that storybook integration is more stable/complete than it was last time we checked. |
Let's hold off until after launch regardless? |
For sure, this is a post-launch task. I'd be thrilled to switch to Vite. Last I checked the blocker wasn't running the Vite integration, it was all the Storybook add-ons we depend on — several didn't run under Vite. But yeah, Vite would be better if we can get things working. |
I'm gonna investigate vite again, see if the ecosystem is more ready than last time we checked. If not, I'll look into webpack 5 |
So vite works (really well!!) Getting twing to work was a big pain (but it was for webpack too), but it works now. I was able to update to the latest twing which is async. I'm ironing out some minor issues but I am planning to send a PR today hopefully! |
Gonna close this and assign myself to #1403 instead. |
Storybook now supports WebPack 5 with a bit of extra configuration: https://storybook.js.org/docs/react/builders/webpack#webpack-5
We have numerous dependencies we can't update because they depend on WebPack 5, so this would be a good upgrade for us.
The text was updated successfully, but these errors were encountered: