Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to WebPack 5 #1953

Closed
spaceninja opened this issue Jul 15, 2022 · 7 comments
Closed

Upgrade to WebPack 5 #1953

spaceninja opened this issue Jul 15, 2022 · 7 comments
Assignees
Labels
👷 dev 🔌 dependencies Pull requests that update a dependency file 🛠 maintenance

Comments

@spaceninja
Copy link
Member

Storybook now supports WebPack 5 with a bit of extra configuration: https://storybook.js.org/docs/react/builders/webpack#webpack-5

We have numerous dependencies we can't update because they depend on WebPack 5, so this would be a good upgrade for us.

@spaceninja spaceninja added 🛠 maintenance 🔌 dependencies Pull requests that update a dependency file size:2 👷 dev labels Jul 15, 2022
@spaceninja
Copy link
Member Author

@calebeby I don't know your availability or how this would prioritize compared to other tasks, but if you had some bandwidth, this would be great to get your eyes on.

@calebeby
Copy link
Member

@spaceninja I would guess this is closer to a 5-10 than a 2. I would rather switch to vite if that storybook integration is more stable/complete than it was last time we checked.

@calebeby
Copy link
Member

Let's hold off until after launch regardless?

@spaceninja
Copy link
Member Author

For sure, this is a post-launch task.

I'd be thrilled to switch to Vite. Last I checked the blocker wasn't running the Vite integration, it was all the Storybook add-ons we depend on — several didn't run under Vite. But yeah, Vite would be better if we can get things working.

@spaceninja spaceninja added size:5 and removed size:2 labels Jul 18, 2022
@tylersticka tylersticka removed the size:5 label Aug 3, 2022
@calebeby calebeby self-assigned this Aug 4, 2022
@calebeby
Copy link
Member

calebeby commented Aug 4, 2022

I'm gonna investigate vite again, see if the ecosystem is more ready than last time we checked. If not, I'll look into webpack 5

@calebeby
Copy link
Member

So vite works (really well!!)

Getting twing to work was a big pain (but it was for webpack too), but it works now. I was able to update to the latest twing which is async.

I'm ironing out some minor issues but I am planning to send a PR today hopefully!

@calebeby
Copy link
Member

Gonna close this and assign myself to #1403 instead.

@calebeby calebeby closed this as not planned Won't fix, can't repro, duplicate, stale Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👷 dev 🔌 dependencies Pull requests that update a dependency file 🛠 maintenance
Projects
None yet
Development

No branches or pull requests

3 participants