Skip to content
This repository has been archived by the owner on Nov 5, 2022. It is now read-only.

SW sample code in explainer doesn't deal with worker being killed #20

Open
mkruisselbrink opened this issue Apr 7, 2016 · 0 comments
Open

Comments

@mkruisselbrink
Copy link

In the "edit a file" example you add event listeners while handling another event. If the service worker gets killed it will never be able to deliver that update event to the service worker since the worker doesn't re-register for th event.

More generally in all the service worker code you do asynchronous operations in event listeners, but don't call "waitUntil" on the event, so the browser will have no way of knowing that it should keep the service worker alive.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant