Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use non-deprecated assertion methods #1243

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use non-deprecated assertion methods #1243

wants to merge 1 commit into from

Conversation

s-t-e-v-e-n-k
Copy link

Both assertDictContainsSubset and assertRaisesRegexp have been deprecated, and removed in Python 3.12. Use assertGreaterEqual on the dictionary items to compare dictionaries instead of assertDictContainsSubset.

Fixes #1242

@s-t-e-v-e-n-k
Use non-deprecated assertion methods
9fc5f15 
Both assertDictContainsSubset and assertRaisesRegexp have been
deprecated, and removed in Python 3.12. Use assertGreaterEqual on the
dictionary items to compare dictionaries instead of
assertDictContainsSubset.

Fixes census-instrumentation#1242
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aabmass aabmass Awaiting requested review from aabmass aabmass is a code owner

@hectorhdzg hectorhdzg Awaiting requested review from hectorhdzg hectorhdzg is a code owner

@jeremydvoss jeremydvoss Awaiting requested review from jeremydvoss jeremydvoss is a code owner

@lzchen lzchen Awaiting requested review from lzchen lzchen is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Testsuite fails on Python 3.12
1 participant
@s-t-e-v-e-n-k