-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(authentication): provide the auto-retrieved SMS verification code #272
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good :)
|
How can I test the branch main? (now that you merged it). Would like to test it again. |
@alexookah I created a new dev build for you:
|
Can I also test this with the messaging? because I am also using the messaging and it's not very easy |
@alexookah Yes, with this release ^^
|
Thanks for the dev build. |
I tested it from a apk that I downloaded from google play console as beta. |
I have ordered a sim card for my android test device. I will get back to you as soon as I have had a chance to test it. |
Hi @robingenz, I have recently started to have a problem related to auto-retrieved SMS in android, does the plugin have any way to disable that mechanism? |
No, you cannot disable this mechanism. See firebase/quickstart-android#296 |
@robingenz you can patch it to stop autoverify: firebase/quickstart-android#296 (comment) Using this patch for a year and had 0 issues so far. |
@efstathiosntonas Thanks for sharing! Would you be willing to create a PR which allows you to set the timeout? Edit: I created an issue for this: #501 |
@robingenz I'd be happy to do so but unfortunatelly I do not use capacitor and I'm not familiar with the source code. 🤷♂️ (I landed here from the reference to this issue from firebase's repo issue) |
@efstathiosntonas All right! Thanks for the tip anyway. I will implement it. |
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run changeset
).Close #252