-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to release - notarization broken #1307
Comments
Hi @perry-mitchell, I can assist you; I've already worked on notarizing an app. Why are you using a fork of Electron Builder action instead of the official Electron Builder? |
Thanks @quintushr - I think I already got it fixed, pending a release later. At least it said it notarized successfully. As far as I'm aware there is no official GitHub action for electron builder. We are using the official electron builder library as well though. The action invokes the builder. Appreciate the help! If it fails I'll definitely ask more from you if you have the time 🙏 |
@perry-mitchell may I ask how you were able to fix the issue? |
I switched to using the electron builder I'm on my phone at the moment but if you check the commits from a couple of weeks ago you'll see the change there. If you can't find it I'm happy to link it later. |
That worked! Thank you very much! I really appreciate it. Some of these electron builder issues are my personal hell xD I added you on LinkedIn, since we seem to share a passion or two, I hope that is alright :) |
Hey that's great to hear! Happy to have helped someone else out of that mess. Agree it's hell. That's why I hate touching it. Yeah of course! Happy to be connected mate. |
Mac notarization is broken, so we can't release new builds: samuelmeuli/action-electron-builder#101
We might have to move to Electron Forge and start again, with the publishing process, as there doesn't seem to be any simple way to force the current configuration to use the new
notarytool
that would be required. Don't particularly want to waste time writing custom notarization scripts either honestly.The text was updated successfully, but these errors were encountered: