Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] handle domain names starting with a number via env var prefix #1857

Open
1 task done
ppenguin opened this issue Jan 5, 2025 · 0 comments
Open
1 task done
Labels
enhancement New feature or request

Comments

@ppenguin
Copy link

ppenguin commented Jan 5, 2025

What's needed and why?

I have several domains (and/or vhosts) starting with a number, and it's impossible to configure BW for them via environment variables.

The reason is that bash doesn't allow environment variables to start with a number.

Implementations ideas (optional)

A simple, consistent and discoverable way would be to allow multi-site variables to have an underscore _ prefix, that will be sanitised when processing. For that matter, one could just allow any processed env var to have a _ prefix and just indiscriminately trim it off as the first processing step. This is safe because domain or host names cannot have underscores.

So something like

_1nteresting.io_REVERSE_PROXY_URL="..."

will lead to a corresponding nginx server config in /etc/nginx/1nteresting.io/ with server_name 1nteresting.io in server.conf (and in all other places where the domain name is used.

Code of Conduct

  • I agree to follow this project's Code of Conduct
@ppenguin ppenguin added the enhancement New feature or request label Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant