Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requesting visual for Percentile Plugin #63

Open
Sapphiratelaemara opened this issue Oct 11, 2018 · 5 comments
Open

Requesting visual for Percentile Plugin #63

Sapphiratelaemara opened this issue Oct 11, 2018 · 5 comments

Comments

@Sapphiratelaemara
Copy link

Would be nice if we could get to see the number from https://github.com/Liquidize/FFXIV_PercentilePlugin
on the overlay so making a humble request <3

@bsides
Copy link
Owner

bsides commented Oct 13, 2018

Hi @Sapphiratelaemara!

Looks like a very nice addition indeed. As I'm not playing the game I couldn't implement it right now but I'll as for help and see what can be done.

Thanks for the input! <3

@unfaiyted
Copy link

@Sapphiratelaemara I'll go ahead and fork this and take a stab at it.

@unfaiyted
Copy link

unfaiyted commented Oct 21, 2018

If you want to test it out I published it here using the settings @bsides
setup and such. I think it is working but I'm going to test it more. Would you like me to create a pull request for this?

  • Adding a setting for FFLogs Pct to the settings config
  • Priority of PCT > Healing
  • If both are on FFLogs PCT will show

https://unfaiyted.github.io/horizoverlay/#/

@bsides
Copy link
Owner

bsides commented Oct 25, 2018

Hi @unfaiyted!

Sure, you can send a PR for it, it would be much appreciated. The bad news though is that I cannot test it right now. I'm not playing the game right now, the subscription is becoming too expensive in my country unfortunately. I'm planning on coming back in the next month or december though. Until then I'd suggest you use your version (or fork mine like you probably did) until I can release a proper one.

Thanks for your efforts again. Send you PR regardless so we can comment on it.

@bsides
Copy link
Owner

bsides commented Jul 4, 2019

Since I wasn't playing until now I couldn't test it. Sorry for it =/

I'm going to attempt to bring it on with the next version of the overlay. If that take too much time, I'll try to push this through.

Thanks again for the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

3 participants