Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No option to display crit/DH rate? #57

Open
wsoxfan1214 opened this issue Jun 13, 2018 · 7 comments
Open

No option to display crit/DH rate? #57

wsoxfan1214 opened this issue Jun 13, 2018 · 7 comments

Comments

@wsoxfan1214
Copy link

Hello! I noticed the discord webhook for the overlay seems to track crit/direct hit rate, bit there doesn't seem to be an option to display these in the settings for the overlay.

Is there any chance this could be added as an option? :)

@bsides
Copy link
Owner

bsides commented Jul 31, 2018

We can track everything ACT and the Overlay plugin allow us to. It's a huge list! I'm afraid to add it as an option because it could potentially bloat the overlay but I could put a maximum of items to be shown and work from there.

The only thing is that I'm not playing right now so I couldn't test or develop. It's going to be a while to do it since the subscription in my currency got higher past months but I'll let you know whenever I can.

Thanks for you suggestion! 👍

@javaJake
Copy link

javaJake commented Mar 2, 2020

I've created a mod that simply swapped the DPS% with crit, direct hit, and combined rates:
master...javaJake:master

I've got a hosted version at:
https://javajake.github.io/horizoverlay/

It's a bit hacky, though, so I expect bsides will want to clean it up and make it look far nicer. I just threw this together for some friends who loved the overlay but wanted those numbers as well.

@Nillinn
Copy link

Nillinn commented Dec 12, 2021

@javaJake I really like your modded version of the overlay. Any plans on updating it for Endwalker? And could you make the death counter separate from the crit/dh counter so it's possible to enable only the former?

@javaJake
Copy link

Thanks for the reminder. I've been meaning to get around to it. I will consider separating the death counter.

@th411d
Copy link

th411d commented Jan 19, 2022

@javaJake I love using your modified overlay, but is it possible to revert to the same font as the original as before?

@Nillinn
Copy link

Nillinn commented Jul 13, 2024

@javaJake Thank you very much for the updates. This is still my favorite overlay after so many years.

If you're still mantaining this code, would you mind adding the new job icons and their role colours to your custom version? We have two new DPS now: Viper and Pictomancer. And their icon/colour don't appear on the overlay.

@bsides
Copy link
Owner

bsides commented Jul 14, 2024

I've created a mod that simply swapped the DPS% with crit, direct hit, and combined rates: master...javaJake:master

I've got a hosted version at: https://javajake.github.io/horizoverlay/

It's a bit hacky, though, so I expect bsides will want to clean it up and make it look far nicer. I just threw this together for some friends who loved the overlay but wanted those numbers as well.

You could also send a PR if you want to, no problem. We could add a menu option for your mods as well :)

For @Nillinn question above, here it's updated, so it's just a matter of merging back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

5 participants