Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crit! path.relative trim first symbol of dirname #21

Open
eXponenta opened this issue Jul 19, 2020 · 1 comment
Open

Crit! path.relative trim first symbol of dirname #21

eXponenta opened this issue Jul 19, 2020 · 1 comment

Comments

@eXponenta
Copy link

eXponenta commented Jul 19, 2020

Description:
Calling path.relative('.', 'root/app') return 'oot/app' instead of 'root/app'

Expected:
'root/app'

Problem at:
https://github.com/browserify/path-browserify/blob/master/index.js#L23

Fiddle (isolated function):
https://jsbin.com/cinaxatugo/1/edit?js,console

@goto-bus-stop
Copy link
Member

goto-bus-stop commented Jul 20, 2020

This is fixed in 1.0.0. I would be happy to do another 0.x release but unfortunately that will still not help for webpack because node-libs-browser is pinned to 0.0.1 and afaik does not receive updates anymore.

for browserify, path-browserify 1.x will be used in browserify 17, which will be released as soon as i have time 😇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants