Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lines in mult-line properties starting with whitespace and dash classified as deletions #6

Open
stempler opened this issue Apr 30, 2024 · 3 comments

Comments

@stempler
Copy link

First of all thanks a lot for creating this nice action! It's a very nice representation of the plan.

I gave it a try today with a case where a resource is added that includes YAML as one of its properties.
It seems that when a line starts with (optional?) whitespace and a dash, like in this case for lists in YAML, the representation in the comment is rendered as deletion although it is just part of the resource property.

Example in created comment:

image

Same in original plan:

image

@borchero
Copy link
Owner

Uh, interesting case, thanks a lot for surfacing! I'll think about how to fix this, I hadn't dealt with plain YAML files in Terraform yet 👀

@stempler
Copy link
Author

Here another example where there is an update to a similar property:

  • First line wrongly classified as deletion ❌
  • Second line correctly classified as deletion ✔️
  • Third line correctly classified as addition/creation ✔️

image

Same excerpt from original plan:

image

@borchero
Copy link
Owner

Yup, all boils down to the same issue! It should be possible to reverse-engineer this, the relevant information should be available 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants