Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] yarn test since the switch to vitest no longer ignores any folders/symlinks added to module-local-dev/ #3171

Closed
2 tasks done
jswalden opened this issue Dec 8, 2024 · 1 comment
Labels
BUG Something isn't working

Comments

@jswalden
Copy link
Contributor

jswalden commented Dec 8, 2024

Is this a bug in companion itself or a module?

  • I believe this to be a bug in companion

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

Running tests for #3170 reports, for me, 42 failing tests -- because I've added ptzoptics-visca and allenheath-sq modules in module-local-dev/ and I get a bunch of tests failing for "Error: Do not import @jest/globals outside of the Jest test environment".

I looked briefly at 9a78803 which swapped from jest to vitest, and it looks like that swap lost an exclusion of files in module-local-dev/. I assume there's some way to do the same with vitest, that's simply missing now, but I don't know it to write the fix.

Steps To Reproduce

Expected Behavior

Environment (please complete the following information)

Additional context

@jswalden jswalden added the BUG Something isn't working label Dec 8, 2024
@Julusian
Copy link
Member

Julusian commented Dec 9, 2024

I've stopped putting my dev modules in that dir, so managed to not notice 😅
This is fixed now

@Julusian Julusian closed this as completed Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants