Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make file operations atomic #57

Open
wisp3rwind opened this issue Oct 30, 2021 · 3 comments
Open

Make file operations atomic #57

wisp3rwind opened this issue Oct 30, 2021 · 3 comments

Comments

@wisp3rwind
Copy link
Member

wisp3rwind commented Oct 30, 2021

As discussed in beetbox/beets#3849 and beetbox/beets#4060, we would like most/all of beets file operations to be atomic. This requires support by mediafile, which in turn either requires that we shuffle around temporary files, or someone invests the time to implement this in mutagen directly, see quodlibet/mutagen#241. Ideally, on CoW file systems, this should use reflinks.

@catap
Copy link

catap commented Oct 30, 2021

@wisp3rwind this seems like a huge project for mutagen to be honest.

Anyway, usually it edits only end of a file which seems fast enough.

Anyway, embeded arts may easy make things slow :(

@wisp3rwind
Copy link
Member Author

Sure, this might involve a lot of work and will depend on a volunteer to do so. I opened this issue to keep track of the problem, since the previous discussion is mostly in the review comments in beetbox/beets#4060 and as such hard to find.

@catap
Copy link

catap commented Oct 30, 2021

@wisp3rwind meanwhie, I'll try to find any motivation to implement a way with tempfiles also here ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants