Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make loona-hpack use RollMut/Piece #191

Open
fasterthanlime opened this issue Jun 4, 2024 · 0 comments
Open

Make loona-hpack use RollMut/Piece #191

fasterthanlime opened this issue Jun 4, 2024 · 0 comments

Comments

@fasterthanlime
Copy link
Collaborator

It uses &[u8], Cow<[u8]> and Vec<u8> respectively, when it should use Piece and others.

Ideally there'd be a way to make it generic over buffer strategies but... for now I'm not sure.

I'm not sure how that all plays with "provided buffers", or whether fluke will end up using them at all with io-uring, so it might be wise to keep this for a bit later.

Just... in benchmarks, I expect allocations to show up since fluke-hpack currently straight up allocates Vecs when it needs to do huffman decoding (see HuffmanDecoder::decode)

@fasterthanlime fasterthanlime changed the title Make fluke-hpack use RollMut/Piece Make loona-hpack use RollMut/Piece Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant