Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain proportions #535

Open
garethfuller opened this issue Jan 31, 2025 · 3 comments
Open

Explain proportions #535

garethfuller opened this issue Jan 31, 2025 · 3 comments
Assignees

Comments

@garethfuller
Copy link
Contributor

https://balancer.fi/pools/ethereum/v3/0xd9005569c381d57506baefb69f90d1bb52a023b9

Image
@garethfuller
Copy link
Contributor Author

@uiuxxx could you help come up with some copy for this warning?

@uiuxxx
Copy link
Contributor

uiuxxx commented Feb 11, 2025

@garethfuller

It's tricky because, in stable pools, there are no target weights, but user's may intuitively feel like if there are two tokens, a proportional add should be close to 50% / 50%.

In this case, something like this could work:

Image

Text:

Proportional adds avoid price impact by matching the current ratio of each token’s USD value within the pool:
{token-1}: 76.26%, {token-2}: 23.74%

However, there are still some questions:

  • Should we add this tip to all Proportional adds? Or just to adds where there is a significant divergence of token ratios, e.g.
    • in a two token pool, if any token USD value is above 55%
    • in a three token pool, if any token USD value is above say 40%
    • etc
  • Does the pool type matter?
    • I don't think so?

@danielmkm
Copy link
Contributor

oof, ya on further consideration this is a tough one. Even in the stable pool situation, it's pretty common for the pool to be "out of balance," but this doesn't necessarily mean there's any issue with the pool assets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants