Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTMLDocument.registerElement is deprecated. #14

Open
masashiro0jack opened this issue Mar 16, 2023 · 2 comments
Open

HTMLDocument.registerElement is deprecated. #14

masashiro0jack opened this issue Mar 16, 2023 · 2 comments

Comments

@masashiro0jack
Copy link

Use customElements.define instead of document.registerElement see https://javascript.info/custom-elements

HTMLDocument.registerElement (file:///opt/Pulsar/resources/app.asar/static/index.js:99:12)
registerElement (/home/famin/.pulsar/packages/buildium/node_modules/space-pen/lib/space-pen.js:66:88)
Builder.openTag (/home/famin/.pulsar/packages/buildium/node_modules/space-pen/lib/space-pen.js:297:27)
Builder.tag (/home/famin/.pulsar/packages/buildium/node_modules/space-pen/lib/space-pen.js:274:12)
Function.div (/home/famin/.pulsar/packages/buildium/node_modules/space-pen/lib/space-pen.js:83:49)
Function.value (/home/famin/.pulsar/packages/buildium/lib/buildium.js:1:37843)
@idleberg idleberg added the duplicate This issue or pull request already exists label Mar 27, 2023
@idleberg idleberg reopened this Mar 28, 2023
@idleberg
Copy link
Collaborator

idleberg commented Mar 28, 2023

While this pack is affected by this deprecation, it needs to be fixed in the space-pen package. But since that has been deprecated by GitHub, the second best choice would be reporting this issue in the space-pen-plus. Once a fix is available, replacing the dependency on that package should be trivial.

The alternative would be rewriting the UI, which probably won't happen anytime soon (if at all).

@idleberg idleberg removed the duplicate This issue or pull request already exists label Mar 28, 2023
@idleberg
Copy link
Collaborator

idleberg commented Jul 1, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants