Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use eslint for JavaScript #28

Open
arnested opened this issue Jan 12, 2013 · 2 comments
Open

Use eslint for JavaScript #28

arnested opened this issue Jan 12, 2013 · 2 comments
Labels

Comments

@arnested
Copy link
Owner

Use flymake-jshint.el for JavaScript.

JSHint will be officially used as coding standard for JavaScript in Drupal 8. See
http://atendesigngroup.com/blog/looking-at-drupal-8-javascript-changes.

@arnested arnested changed the title Use flymake-jshint.el for JavaScript Use eslint for JavaScript Jul 28, 2014
@arnested
Copy link
Owner Author

ESLint is the official linting tool for Drupal 8 now (see #2274223) so we should probably use that instead (although there is now flymake-eslint.el (yet).

@xendk
Copy link
Collaborator

xendk commented Jul 29, 2014

Theres ESLint support in flycheck, it just requires one to disable the jshint checker.

The question is whether to just disable jshint buffer locally for Drupal js files, and assume that eslint is available, or do it the proper way and detect whether eshint is installed and only disable jshint in that case. The latter is more proper, but the former is probably easier.

Though flycheck has flycheck-may-use-checker which can tell us whether a checker may be used in the current buffer, which should make it fairly easy to fix up the flycheck-disabled-checkers in some hook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants