chore(deps): update Go to 1.24 and switch to go-version-file #8388
+13
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the Go version across multiple files from 1.23 to 1.24, including: - .golangci.yaml - Dockerfile.protoc - go.mod - GitHub workflow files - Magefile golangci-lint version Additionally, workflow files now use go-version-file instead of hardcoded GO_VERSION environment variable.
knqyf263
commented
Feb 12, 2025
| @@ -1,4 +1,4 @@ | |||
| FROM --platform=linux/amd64 golang:1.23 | |||
| FROM --platform=linux/amd64 golang:1.24 | |||
There was a problem hiding this comment.
Not released yet as of today.
https://hub.docker.com/_/golang/tags
Signed-off-by: knqyf263 <[email protected]>
|
Looks like TinyGo doesn't support Go 1.24. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR updates Go to version 1.24 and changes how we manage Go versions in GitHub Actions from
go-versiontogo-version-file.Description
This PR includes the following changes:
go-versiontogo-version-filein GitHub Actions workflowsThe switch to
go-version-filewas made to improve version management clarity and reduce confusion. Previously, we had a discussion in #6711 about usinggo-versionto automatically use the latest patch version. However, this approach led to confusion as the version specified in the workflow could differ from the one in go.mod.For example, in #8341, we unnecessarily updated the Go version even though the latest patch version would have been used during the release anyway. To avoid such confusion, it looks better to manage Go versions explicitly through go.mod and use
go-version-filein workflows. This approach:Related PRs
v1.23.5#8341Checklist