Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(image): do not export entrypoint to Dockerfile #8366

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(image): do not export entrypoint to Dockerfile #8366

wants to merge 1 commit into from

Conversation

nikpivkin
Copy link
Contributor

Description

The AVD-DS-0007 check should only be applied to the final layer. This PR removes the recently added export of the etrypoint instruction to the Dockerfile and fixes a bug with exporting metadata instructions.

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@nikpivkin
Copy link
Contributor Author

@simar7 Should we just disable the AVD-DS-0007 check when analyzing the image history like we did for #7368 ? Right now we have only one check that analyzes the entrypoint instruction but we may add more in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knqyf263 knqyf263 Awaiting requested review from knqyf263 knqyf263 will be requested when the pull request is marked ready for review knqyf263 is a code owner

@DmitriyLewen DmitriyLewen Awaiting requested review from DmitriyLewen DmitriyLewen will be requested when the pull request is marked ready for review DmitriyLewen is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(checks): Only One Entrypoint false negative
1 participant
@nikpivkin