Initial isLoading state error when auto connect is disabled

[Metal-joker]

The isLoading state should represent whether there's an action ongoing, but when autoConnect is set to false, the initial isLoading state seems to always be true.

aptos-wallet-adapter/packages/wallet-adapter-react/src/WalletProvider.tsx

Lines 56 to 58 in 5ea35e6

	// a local state to track whether wallet connect request is loading
	// https://github.com/aptos-labs/aptos-wallet-adapter/issues/94
	const [isLoading, setIsLoading] = useState<boolean>(true);

aptos-wallet-adapter/packages/wallet-adapter-react/src/WalletProvider.tsx

Lines 143 to 152 in 5ea35e6

	useEffect(() => {
	if (autoConnect) {
	if (localStorage.getItem("AptosWalletName") && !connected) {
	connect(localStorage.getItem("AptosWalletName") as WalletName);
	} else {
	// if we dont use autoconnect set the connect is loading to false
	setIsLoading(false);
	}
	}
	}, wallets);

aptos-wallet-adapter/packages/wallet-adapter-react/src/WalletProvider.tsx

Lines 260 to 280 in 5ea35e6

	return (
	<WalletContext.Provider
	value={{
	connect,
	account,
	network,
	connected,
	disconnect,
	wallet,
	wallets,
	signAndSubmitTransaction,
	signTransaction,
	signMessage,
	signMessageAndVerify,
	isLoading,
	submitTransaction,
	}}
	>
	{children}
	</WalletContext.Provider>
	);

[servroxsolutions]

Can confirm.

[gsong]

I attempted the obvious fix but that didn't resolve the issue, unfortunately. So I'm using a workaround in the meantime:

import { useWallet as useWalletImpl } from "@aptos-labs/wallet-adapter-react";

export const useWallet = () => {
  const { connected, ...wallet } = useWalletImpl();
  const isLoading = useIsLoading();

  const connectedStatus = isLoading ? undefined : connected;

  return { ...wallet, connected: connectedStatus, isLoading };
};

const useIsLoading = () => {
  const { wallets, isLoading } = useWalletImpl();

  return isLoading || !wallets || wallets.length === 0;
};