Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RefreshSegmentTaskGenerator: Evaluate and Use Server APIs to determine if refresh is needed. #14483

Open
vvivekiyer opened this issue Nov 18, 2024 · 1 comment

Comments

@vvivekiyer
Copy link
Contributor

PR #14300 talks about the reasoning for triggering no-op minion tasks when there are table config updates.

Cons of this approach is that there will be minion tasks created for all segments for each table config update.

To overcome this problem, we can use a server side API that will return the list of segments to be refreshed. It is being developed in #14450.

@tibrewalpratik17
Copy link
Contributor

Copying from comment - https://github.com/apache/pinot/pull/14596/files#r1870200378

One improvement in this task can be to keep the default number of tasks execution is equal to number of partitions in a table and we process one segment per partition (or instance) by default. This way the load gets normalised across hosts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants