Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating table instances should also load hudi-defaults.conf #111

Closed
xushiyan opened this issue Aug 11, 2024 · 2 comments · Fixed by #118
Closed

Creating table instances should also load hudi-defaults.conf #111

xushiyan opened this issue Aug 11, 2024 · 2 comments · Fixed by #118
Assignees
Labels
Milestone

Comments

@xushiyan
Copy link
Member

During crates/core/src/table/mod.rs:96 load_configs<I, K, V>, hudi global configs (a hudi-defaults.conf file loaded in dir specified by HUDI_CONF_DIR env var) should be loaded as well.

@xushiyan xushiyan added this to the release-0.2.0 milestone Aug 11, 2024
@gohalo
Copy link
Contributor

gohalo commented Aug 20, 2024

i could work on that if no one plan for.

As externalized-config-file described , should scan all files under HUDI_CONF_DIR directory, and maybe filter with *.conf.

And i havn't found the format of this file, maybe properties, ini etc. Just got some ideas from Hudi Issues #5291, like the following.

# Default system properties included when running Hudi jobs.
# This is useful for setting default environmental settings.

# Example:
hoodie.datasource.write.table.type                      COPY_ON_WRITE
hoodie.datasource.write.hive_style_partitioning         false

@xushiyan
Copy link
Member Author

@gohalo great! as per the linked doc, only hudi-defaults.conf should be loaded under HUDI_CONF_DIR. The format should be like a conf file as you showed or delimited by = like

hoodie.datasource.write.recordkey.field=uuid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants