You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This issues is repeated in zrender issue 1066. This stack overflow is caused by a clone utility that does not guard against circular reference. And this clone process is initiated by OptionManagerhere. According to comments, cloneing here serves the purpose of avoiding modifying the user supplied option argument. In that regard, I suppose it's more robust to guard against circular references when cloneing.
Circular reference is perfectly valid and reasonable in many cases. For example, series-sunburst accepts tree-like series.data and a user may store a parent link in every tree node so that click handlers on this chart can construct a path from node to tree root easily.
The text was updated successfully, but these errors were encountered:
Version
5.5.0
Link to Minimal Reproduction
https://echarts.apache.org/examples/zh/editor.html?c=sunburst-simple&code=MYewdgzgLgBATiEsC8MDeAoGNgAsCWANgCZwCmYAXDANoC6GAvgNwaiSwCGMqm2ADp3Jgo1BEiatxUAHR4ipCjP4BXCLgAUnAJSsMIflHzge6LDAhk4-MhGp9sMKAE9-ZagHIIKsACMVcNAeADTm2MScUJzUNNIM2IySQA
Steps to Reproduce
Current Behavior
In step 2, a
RangeError: Maximum call stack size exceeded
is thrown and the chart is not displayed.Expected Behavior
Chart is displayed properly.
Environment
Any additional comments?
This issues is repeated in zrender issue 1066. This stack overflow is caused by a clone utility that does not guard against circular reference. And this clone process is initiated by
OptionManager
here. According to comments,clone
ing here serves the purpose of avoiding modifying the user supplied option argument. In that regard, I suppose it's more robust to guard against circular references whenclone
ing.Circular reference is perfectly valid and reasonable in many cases. For example, series-sunburst accepts tree-like
series.data
and a user may store a parent link in every tree node so that click handlers on this chart can construct a path from node to tree root easily.The text was updated successfully, but these errors were encountered: