migrate string functions to inovke_with_args
#14722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @goldmedal |
zjregee
force-pushed
the
migrate-string-functions
branch
from
54f5be7 to
3a24290
Compare
goldmedal
reviewed
Feb 17, 2025
Comment on lines
43
to
46
| criterion::black_box( | ||
| concat() | ||
| .invoke_with_args(ScalarFunctionArgs { | ||
| args: args.clone(), |
There was a problem hiding this comment.
Maybe we can move clone out of black_box. It can decrease the impact of clone for the benchmark result. (It's more close to the previous version.)
Suggested change
| criterion::black_box( | |
| concat() | |
| .invoke_with_args(ScalarFunctionArgs { | |
| args: args.clone(), | |
| let args_cloned = args.clone(); | |
| criterion::black_box( | |
| concat() | |
| .invoke_with_args(ScalarFunctionArgs { | |
| args: args_cloned, |
In my laptop, if we place clone in the black_box, the result will slow down by about 5%.
There was a problem hiding this comment.
I think other benchmark cases can be improved by moving out the clone().
There was a problem hiding this comment.
Thanks for your suggestion, I have optimized this in the submission.
zjregee
force-pushed
the
migrate-string-functions
branch
from
3751730 to
942c3a8
Compare
zjregee
force-pushed
the
migrate-string-functions
branch
from
942c3a8 to
b19ae17
Compare
|
And I noticed that #14686 introduced a call |
|
🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
inovke_with_args#14708.Rationale for this change
What changes are included in this PR?
Deprecate and remove
invoke_batchin string functions and migrate to providinginvoke_with_args.Are these changes tested?
Yes.
Are there any user-facing changes?
None.