Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Regex function to invoke_with_args #14707

Closed
goldmedal opened this issue Feb 17, 2025 · 1 comment · Fixed by #14728
Closed

Migrate Regex function to invoke_with_args #14707

goldmedal opened this issue Feb 17, 2025 · 1 comment · Fixed by #14728
Assignees
@irenjj
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@goldmedal
Copy link
Contributor

Is your feature request related to a problem or challenge?

As #14652, invoke_batch is deprecated. We should migrate all the UDFs to invoke_with_args. This issue would focus on the function in the datafusion/functions/src/regex.

Describe the solution you'd like

  • Remove invoke_batch for the function implementation and use implement invoke_with_args instead.

Describe alternatives you've considered

No response

Additional context

No response
@goldmedal goldmedal added enhancement New feature or request good first issue Good for newcomers labels Feb 17, 2025
@niebayes niebayes mentioned this issue Feb 17, 2025
Open
@irenjj
Copy link
Contributor

irenjj commented Feb 17, 2025

take

@irenjj irenjj mentioned this issue Feb 17, 2025
Merged
@Chen-Yuan-Lai Chen-Yuan-Lai mentioned this issue Feb 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@irenjj irenjj

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Migrate Regex function to invoke_with_args irenjj/datafusion
2 participants
@goldmedal @irenjj