Allow extensions_options to accept Option field #14664
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
no related issue.
Rationale for this change
We allow users to define the custom config by
extensions_options
likeHowever, the
Option
type isn't allowed. It's hard to handle the null value case.This PR allows user to define the field like
What changes are included in this PR?
ConfigField,
which has been implemented for many data types, within the macro.Are these changes tested?
add unit test.
Are there any user-facing changes?
New behavior for
extensions_options
macro