Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply take_function_args to functions validating argument count #14516

Open
findepi opened this issue Feb 5, 2025 · 2 comments · May be fixed by #14525
Open

Apply take_function_args to functions validating argument count #14516

findepi opened this issue Feb 5, 2025 · 2 comments · May be fixed by #14525
Assignees
@lgingerich
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@findepi
Copy link
Member

findepi commented Feb 5, 2025

#14513 introduced a heper to make code more readable and error messages more consistent.
apply the pattern in other functions

candidate places to update can be listed using

git grep -n 'if args\?\(_types\)\?.len() != '

(note that this may yield false positives, ie places that should not be updated)
@findepi findepi added good first issue Good for newcomers help wanted Extra attention is needed labels Feb 5, 2025
@findepi findepi mentioned this issue Feb 5, 2025
Merged
@lgingerich
Copy link

take

@findepi findepi mentioned this issue Feb 6, 2025
Open
@lgingerich lgingerich linked a pull request Feb 6, 2025 that will close this issue
Open
@Ramjee194
Copy link

changes the issue

Image#14516

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lgingerich lgingerich

Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use take_function_args in more places lgingerich/datafusion
3 participants
@findepi @lgingerich @Ramjee194