Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discuss: Check in Cargo.lock file? #14135

Closed
alamb opened this issue Jan 15, 2025 · 2 comments · Fixed by #14483
Closed

Discuss: Check in Cargo.lock file? #14135

alamb opened this issue Jan 15, 2025 · 2 comments · Fixed by #14483
Labels
enhancement New feature or request

Comments

@alamb
Copy link
Contributor

alamb commented Jan 15, 2025

Is your feature request related to a problem or challenge?

Broken out of a discussion on a PR here:

As described in https://github.com/apache/datafusion?tab=readme-ov-file#dependencies-and-a-cargolock

DataFusion currently does not check in Cargo.lock which was the recommendation for earlier versions of Rust

@mbrobbel has a good point here #14069 (comment) that the guidance for Cargo.lock and library files has changed

See https://blog.rust-lang.org/2023/08/29/committing-lockfiles.html

Describe the solution you'd like

TLDR it sounds like the rust team now suggests always committing Cargo.lock and letting dependabot handle updates. That seems like a good idea to me

@gatesn suggested

Just my two cents, but I have found Renovate to be much more configurable. Here's an example of a lock file maintenance PR: spiraldb/vortex#1818

Though One thing we have to be aware of in DataFusion is that as part of the Apache security posture, only certain third party actions are allowed -- we would have to double check Rennovate

Describe alternatives you've considered

No response

Additional context

No response

@Omega359
Copy link
Contributor

Omega359 commented Feb 3, 2025

100%. IMHO dependency updates should only ever happen via a PR/git pull, not like what happens now with cargo.

This was referenced Feb 4, 2025
@findepi
Copy link
Member

findepi commented Feb 4, 2025

Since it would be a very important step towards re-buildable releases (and then also to strictly reproducible builds) - #14479 - i am for adding cargo.lock file to the repository.

Additional benefit is that this would also simplify datafusion-cli build. No longer split brain for local compilation 🚀 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants