Fix partition creation to handle MAXVALUE in subpartition bounds #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the simplified partition creation syntax in GPDB did not properly handle MAXVALUE as a boundary value for subpartitions. The fix allows users to define subpartitions with MAXVALUE boundaries using the simplified partition creation syntax, maintaining compatibility with existing partition functionality. During the fix, it was also identified that MINVALUE has a similar issue. However, addressing MINVALUE is more complex due to the current implementation of the START/EVERY/END grammar, which only considers the end boundary situation. A broader refactor of the partition creation logic may be required to properly support MINVALUE in subpartition definitions. Fixes: apache#795 Authored-by: Zhang Mingli [email protected]
Open
2 tasks
my-ship-it
approved these changes
Feb 6, 2025
yjhjstz
reviewed
Feb 7, 2025
| /* | ||
| * ColumnRef is not in the desired single-field-name form. For | ||
| * consistency between all partition strategies, let the | ||
| * expression transformation report any errors rather than |
There was a problem hiding this comment.
The cname will be NULL when the ColumnRef does not conform to the expected single-field-name format. As stated in the comment, this is a safeguard for consistency across all partition strategies. By allowing the expression transformation to report any errors in such cases, we can prevent potential crashes that might occur from processing invalid ColumnRef structures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the simplified partition creation syntax in GPDB did not properly handle MAXVALUE as a boundary value for subpartitions.
The fix allows users to define subpartitions with MAXVALUE boundaries using the simplified partition creation syntax, maintaining compatibility with existing partition functionality.
During the fix, it was also identified that MINVALUE has a similar issue.
However, addressing MINVALUE is more complex due to the current implementation of the START/EVERY/END grammar, which only considers the end boundary situation.
A broader refactor of the partition creation logic may be required to properly support MINVALUE in subpartition definitions.
Fixes: #795
Authored-by: Zhang Mingli [email protected]
Fixes #ISSUE_Number
What does this PR do?
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions