Fix config file in proj dirrectory #4143
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssbarnea
changed the title
for more information, see https://pre-commit.ci
Qalthos
force-pushed
the
molecule-config-file
branch
from
d2fe3ae
to
650bf8a
Compare
|
Closed due to being abandoned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves the issue raised in Issue #4142 where Molecule does not find the config.yml file the project directory
{project_dir}/.config/molecule/config.ymlbut does find it in the home directory.I ran tests by isolating the 2 functions being called when
LOCAL_CONFIGvariable is defined and verifying that the config file is found when in the project dir. If there is no{project_dir}/.config/molecule/config.ymlthen it looks in~/.config/molecule/config.ymland finds the config file.I have not been able to test the full project with the
toxcommand as my environment is having issues. Thetoxtests are not completing even on a freshly cloned repo.The code in the find_vcs_root function could likely be modified more as it does not appear to be called elsewhere and it searches for ".git", ".hg", ".svn" dirs as well for what appears to be no reason as far as I can tell since it is only used for locating
.config/molecule/config.ymlLet me know if anything can be improved upon here with my delivery of this as it is my first PR with the project.
Fixes: #4142