Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sending a file again appends file to existing. Result is data corruption #444

Open
YesThatGy opened this issue Aug 30, 2024 · 1 comment

Comments

@YesThatGy
Copy link

Note: Please report any security issues directly to hello [at] ankit.pl

Describe the bug
A clear and concise description of what the bug is.

If I send a file to tus-php, and then send the same file again, it appends the a second copy of the file to the end of the first uploaded copy.

To Reproduce
Steps to reproduce the behavior:

  1. Upload a file, EG: "myfile.txt".
  2. Upload the same file again.
  3. In my upload folder, "myfile.txt" is now 2x as long as original.

Expected behavior
A clear and concise description of what you expected to happen.
At step 2, I should receive a link to the file instead of a "starting at 0" response.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

@aln-1
Copy link

aln-1 commented Oct 15, 2024

+1 for this

More info:
you can verify this by using Uppy client and using the Tus option removeFingerprintOnSuccess: true
This will also happen for resume if the browser's local storage was cleared in between.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants