Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report: Library dependencies in unit tests out of date #1153

Open
ciheanyi opened this issue Apr 23, 2022 · 1 comment
Open

Bug Report: Library dependencies in unit tests out of date #1153

ciheanyi opened this issue Apr 23, 2022 · 1 comment

Comments

@ciheanyi
Copy link

Describe the bug

When running the provided unit tests for this repo receiving error:
"ImportError: cannot import name 'Markup' from 'jinja2'"
After further investigaton, discovered that Jinja2>=2.10.1 deprecated Markup command

To Reproduce

Steps to reproduce the behavior:

  1. Submit a pull request with a commit
  2. Code runs on unit tests
  3. See error

Screenshots

Screen Shot 2022-04-22 at 11 12 21 PM

Desktop (please complete the following information):

  • OS: IOS
  • Browser: Chrome
  • Version: 22

Additional context

potentially use this instead to fix:

from jinja2.utils import markupsafe
markupsafe.Markup()
Markup('')

OR have to change dependency versions, when done locally all unit tests ran as usual

@welcome
Copy link

welcome bot commented Apr 23, 2022

Hello there!👋 Welcome to the project!💖

Thank you and congrats 🎉 for opening your very first issue in this project.
AnitaB.org Open Source is an inclusive community, committed to creating a safe and positive environment 🌸 Please follow our Code Of Conduct 🙌
You can learn more about the community on our website and documentation repository.

You may submit a PR on the same if you like!
Please follow our Commit Message Style Guide and Coding Standards while sending PRs.
If you want to report a bug 🐞, please follow our bug_report.md template. Please make sure you include steps to reproduce it and be patient we will get back to you as soon as we can 👀

Also, feel free to join us on AnitaB.org Open Source Zulip Community 🤝 We have different streams for each active repository for discussions.👩🏻‍💻🧑🏻‍💻
For mentorship-backend, join #mentorship-system stream! Hope you have a great time here :)

@ciheanyi ciheanyi changed the title Bug Report: Library dependencies in unit tests out of data Bug Report: Library dependencies in unit tests out of date Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant