Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💚FluidResistance: Remove duplicate, invalid base units #1511

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

angularsen
Copy link
Owner

@angularsen angularsen commented Feb 4, 2025

Removing all base units except for PascalSecondPerCubicMeter and PascalMinutePerCubicMeter.
Duplicate base units caused SI UnitSystem tests to fail.

Removing all base units except for the base unit and one more trivial variant.
@angularsen
Copy link
Owner Author

@lipchev To fix the broken tests, I went ahead and remove most of the BaseUnits since it was not trivial for me to determine all of them.

Just a heads up for when we merge into v6, and if you want to, you can add the correct definitions for the BaseUnits you think we should keep.

@angularsen angularsen merged commit a84780d into master Feb 4, 2025
1 check was pending
@angularsen angularsen deleted the agl/fixup branch February 4, 2025 07:45
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84%. Comparing base (55f0e23) to head (4b622b8).
Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #1511    +/-   ##
=======================================
  Coverage      84%     84%            
=======================================
  Files         368     370     +2     
  Lines       35606   35910   +304     
=======================================
+ Hits        30005   30271   +266     
- Misses       5601    5639    +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lipchev
Copy link
Collaborator

lipchev commented Feb 5, 2025

@lipchev To fix the broken tests, I went ahead and remove most of the BaseUnits since it was not trivial for me to determine all of them.

Same here, I've got such an acute PTSD from these that as long as they aren't wrong- I don't care.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants