-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JetStream crashes on home screen #136
Comments
There are issues with a similar repro too - if you navigate around quickly (up and down) on the home screen: - which looks related to (https://issuetracker.google.com/issues/312677265#comment1)
|
compose tv alpha9-10 weird issue here: new stack trace:
This used to work on alpha08 before. I can't rollback to alpha08 since it throws random NoMethodFound/NoClassFound errors. |
Any progress on this issue? Removing the focusRestorer modifier prevents the app from crash..
|
Best workaround I used for now is to use the custom focusRestorer factory and modify it to catch exceptions if ever Until then, we just have to wait for a fix. EDIT: This doesn't fully fix the crashes, but it should do the trick |
have you got any solution ? |
@Daio-io have you got any solution ? |
@rhenwinch have you got any solution? |
@GeorgiBurgazliev do you get any solution ? |
@ChetanPatelPlayBoxTV For now we are just throttling input to reduce scroll speed as a bit of a bandaid so we can upgrade Compose etc until a full solution is available. This seems to be working in our tests but it is not bullet proof. We just use a preview key modifier and a throttle factor to handle onPreviewKeyEvent { previewKey ->
if (keyCodes.contains(previewKey.key.nativeKeyCode))
if (previewKey.nativeKeyEvent.repeatCount % throttleFactor != 0)
return@onPreviewKeyEvent true
return@onPreviewKeyEvent false
} Just wrapped in our own Modifier :) |
@Daio-io what is ideal throttleFactor are you used? like throttleFactor = 2 or something else |
Also seeing a crash on 4k emulator API 34 when moving the focus around rapidly: java.lang.IllegalStateException: Searching for active node in inactive hierarchy
|
Looks like there is a potential fix in newer versions of Compose: https://issuetracker.google.com/issues/312677265#comment9 (not tested) |
|
Hey Bro any update @chikoski @Daio-io @randroid88 @rhenwinch @GeorgiBurgazliev ? |
--------- beginning of crash |
This issue is fixed as #168 migrates androidx.compose.foundation:foundation to 1.7.0-beta01, which includes the fix for this issue. |
@chikoski Is androidx.tv:tv-foundation deprecated? Should we migrate to androidx.compose.foundation:foundation ? |
Sometimes JetStream's home screen crashes when I move focus from the Iist in the ImmersiveList to other lists. The following is the stack trace:
The text was updated successfully, but these errors were encountered: