Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project won't compile #146

Closed
JanGorman opened this issue Feb 17, 2013 · 7 comments
Closed

Project won't compile #146

JanGorman opened this issue Feb 17, 2013 · 7 comments

Comments

@JanGorman
Copy link

Hi there,

I checked out the source but currently the project doesn't compile (and I saw on your Jenkins page that it isn't running there either). Any plans to update the git repo to get it back running again? I love FEST, wouldn't mind getting involved in the development of it.

@dwursteisen
Copy link

Same issue here.
The problem comes from the commit 715a0f9

@joel-costigliola
Copy link
Contributor

Fest current build is very unstable as Alex (Fest creator) is doing a major refactoring. He has pushed his unfinished work to be able to continue working on it hence the broken build. I don't know when this refactoring will be finished.

contributors are welcome in Fest modules : Guava and Joda Time time ;-)

I'm closing this issue as it's a known temporary state

@dwursteisen
Copy link

Have you any idea of when this refactoring will ending ?
And why Alex haven't created a refactoring branch ? So he can commit in it without breaking the main branch, and, as observer, we can see where fest-assert is going, so we can prepare/update our code base/pull request.

Regards

@joel-costigliola
Copy link
Contributor

I have no news right now ... :(
I agree with the refactoring branch.

@alexruiz
Copy link
Owner

Yes, I should have created a refactoring branch. My bad. I underestimated the amont of things that are wrong in the 2.x repository.

Having said that, I don't see the point of updating to the 2.0Mn codebase. A lot of things are going to change once I'm done. It is taking longer than expected.

The breaking point was the release of FEST-Assert 2.0 M8. I should not have let it happen. There were breaking changes in FEST-Util. I should have waited to release all the FEST modules at once using the new FEST-Util.

I'm currently updating FEST-Assert 1.x, FEST-Swing and FEST-Reflect to use the same latest versions of dependencies. It is a lot of work, but I'm getting there.

@dwursteisen
Copy link

Thanks for your feedback 👍

Because a new branch 2.0M9 exist, may be you can setup this branch as default branch on github and building this branch on jenkins ?

Because you have some false negative issues, like this one or #139 and #148, you may loose time for nothing.

(This is just a suggestion)

Regards

@joel-costigliola
Copy link
Contributor

Good idea, I have just switched branch in our jenkins (hosted by Cloudbees) and now build is back to successful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants