Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subtitle file failed #61

Open
20NE opened this issue Jan 25, 2023 · 12 comments
Open

Add subtitle file failed #61

20NE opened this issue Jan 25, 2023 · 12 comments

Comments

@20NE
Copy link

20NE commented Jan 25, 2023

There is option "-s" to add subtitles file in CLI mode, but doesn't work.
I tried:

  • rename subtitle filename to the same as video filename.
  • add "-tc" option.
  • on http url media or local video file.

All failed.
It seems DLNA doesn't support subtitle.

@alexballas
Copy link
Owner

Hello, I tested it and it works fine on my TV. What device are you using? (model name etc)
Maybe this is a limitation with your TV / Device since not all devices support DLNA subtitles.

@20NE
Copy link
Author

20NE commented Jan 26, 2023

Xiaomi TV, I haven't tried on any other device yet

@alexballas
Copy link
Owner

alexballas commented Jan 26, 2023

Unfortunately this looks like a Xiaomi specific issue. Go2TV uses UPNP/DLNA to communicate and cast media to the devices. Subtitles support is not part of UPNP specification. There are some vendors however that introduced some proprietary extensions to the protocol to support subtitles like Samsung and Panasonic but this is not the case for every TV out there.

It would be good if you could test it with a different device. I personally tested it on Samsung and LG TVs and the subtitles work fine.

@alexballas alexballas closed this as not planned Won't fix, can't repro, duplicate, stale Jun 1, 2023
@nakhla
Copy link

nakhla commented Oct 26, 2024

sorry for commenting to a closed issue, but i think it is related.
I tried go2tv on bubbleupnp and it works for video and subtitle but for samsung j5200 subtitle not shown
i have tried gerbera and it works on same tv for video and subtitle, i am available if i can do any other tests.
thanks

@alexballas
Copy link
Owner

Hello @nakhla,
Unfortunately there is very little here to work with as I personally don't own a J5200. Do you have any other device you could test it with?
I'm also not aware how gerbera does it. You could potentially sniff the XML requests that gerbera sends to your device and see how the subtitle were implemented in the gerbera code.

@alexballas alexballas reopened this Oct 27, 2024
@nakhla
Copy link

nakhla commented Nov 4, 2024

yes i tested with a tu7000 and go2tv is working for video and subtitle flawlessly, i make further test with gerbera on tu7000 and found that subtitle is not working.
so when gerbera work go2tv is not and when go2tv work gerbera is not working.
and i noticed go2tv is working in newly manufactured tvs and gerbera working in quiet old tvs

@alexballas
Copy link
Owner

FYI, I've been working on some improvements around transcoding (requires ffmpeg). With the upcoming version of Go2TV and assuming you have ffmpeg installed or the version from flathub, you should be able to bake the subtitles into the video. Stay tuned :)

@oyyh7
Copy link

oyyh7 commented Jan 26, 2025

我的字幕推送也无效,加载的字幕无法在电视上显示。
Image
Image

@alexballas
Copy link
Owner

我的字幕推送也无效,加载的字幕无法在电视上显示。
Translation: My subtitle push is also not working, the loaded subtitles cannot be displayed on the TV.

Hello @oyyh7,
With the latest version 1.8.0 if you check the transcode checkbox (转码) you can bake the subtitles into the video as an alternative

@oyyh7
Copy link

oyyh7 commented Jan 27, 2025

我的字幕推送也无效,加载的字幕无法在电视上显示。
Translation: My subtitle push is also not working, the loaded subtitles cannot be displayed on the TV.

Hello @oyyh7, With the latest version 1.8.0 if you check the transcode checkbox (转码) you can bake the subtitles into the video as an alternative

勾选了“转码”功能,也无法显示,甚至视频都无法在电视上播放了。

@nakhla
Copy link

nakhla commented Feb 6, 2025

我的字幕推送也无效,加载的字幕无法在电视上显示。
Translation: My subtitle push is also not working, the loaded subtitles cannot be displayed on the TV.

Hello @oyyh7, With the latest version 1.8.0 if you check the transcode checkbox (转码) you can bake the subtitles into the video as an alternative

i tried version 1.18 with transcode and it worked, as expected more cpu usage , but my concern now is i want to get change font size and type, now the subtitles are baked inside video, is there away to change font setting while baking??

@alexballas
Copy link
Owner

我的字幕推送也无效,加载的字幕无法在电视上显示。
Translation: My subtitle push is also not working, the loaded subtitles cannot be displayed on the TV.

Hello @oyyh7, With the latest version 1.8.0 if you check the transcode checkbox (转码) you can bake the subtitles into the video as an alternative

i tried version 1.18 with transcode and it worked, as expected more cpu usage , but my concern now is i want to get change font size and type, now the subtitles are baked inside video, is there away to change font setting while baking??

1.18 does not offer the ability to change the subtitle size in ffmpeg. I cound expose a config in the future to enabled this functionality but that would be only specific to ffmpeg and it could confuse people trying to get different subtitle sizes when casting without ffmpeg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants