Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit sources with multiple primary keys and confirm that this is representative #31757

Closed
evantahler opened this issue Oct 23, 2023 · 2 comments

Comments

@evantahler
Copy link
Contributor

evantahler commented Oct 23, 2023

From https://docs.google.com/document/d/1pIUwLiVrg4HwmynZuosinJjJA6mZ8ENUnJLqOqMdOQo/edit

These sources have streams with multiple PKs, but they are not always non-null. How can that be? Is this intended to be a composite PK?

  • Facebook Marketing
  • Google Ads
  • Mixpanel

Report the results of this audit on #31758

@evantahler evantahler changed the title Audit sources with multiple primary keys and confirm that this is representitive Audit sources with multiple primary keys and confirm that this is representative Oct 23, 2023
@lazebnyi
Copy link
Collaborator

lazebnyi commented Nov 1, 2023

For Facebook Marketing we have multiple PK for insights streams - ["date_start", "account_id", "ad_id"] + self.breakdowns and look like sometimes Facebook can return None for those fields. For example action_type is breakdown field for AdsInsightsActionType and we expect that Facebook must return it as non-null value.

The same logic for Google Ads. We have multiple PK for streams with field that must be present in records.

For Mixpanel we have only two streams with multiple PK:

Export (export events data) - ["distinct_id", "event", "time"]
Funnels (return list of funnels) - ["funnel_id", "date"]

And it look like all field must be non-null value. So, may be present unexpected bug from Mixpanel side.

cc @oustynova

@bnchrch
Copy link
Contributor

bnchrch commented Dec 6, 2023

Resolved as of #31758

@bnchrch bnchrch closed this as completed Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants