Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Please follow the rules of SemVer! #2130

Closed
prokopsimek opened this issue Feb 14, 2025 · 3 comments
Closed

[Bug] Please follow the rules of SemVer! #2130

prokopsimek opened this issue Feb 14, 2025 · 3 comments
Labels
bug Something isn't working

Comments

@prokopsimek
Copy link

prokopsimek commented Feb 14, 2025

There are breaking changes between versions 1.0.8 and 1.1.0. Such as this: v1.0.8...v1.1.0#diff-26675fc047d31ed224b97b138f59e9eadb2b20b8656c5641899526fc7db8dc75

Could you follow the rules of Semver.org to avoid mistakes?

Thanks!

@prokopsimek prokopsimek added the bug Something isn't working label Feb 14, 2025
@dirkbrnd
Copy link
Contributor

Hi @prokopsimek
We don't follow SemVer exactly, because it doesn't suit the pace of our project perfectly. We don't think it would be appropriate to do a major version bump for small but necessary breaking changes (sometimes related to 3rd parties that change).

If we introduce a breaking change, we will update the minor version, and reserve major versions for large reworks that changes a lot of the developer experience. Our product is still in relatively early stages of development, so breaking changes could happen, and we try and document this as best as possible.

I will make an effort to document our versioning strategy so it is more visible.

@prokopsimek
Copy link
Author

Hi @dirkbrnd, thanks for the explanation. I now understand your versioning and can keep track of even minor releases. I’d also recommend clearly stating breaking changes in your releases to make it easier to identify what needs to be updated. I understand that you're still in the early stages of development, so maybe that can come later.

I must say that the learning curve of Phidata/Agno is the best compared to other agentic frameworks. Keep up the great work! I’d love to see improvements in versioning and the changelog to ensure I can upgrade my dependencies smoothly. :-)

@dirkbrnd
Copy link
Contributor

@prokopsimek thanks for the feedback! I'll make it a separate heading in the changelog to ensure it is communicated correctly. I'll try and update it retrospectively as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants