Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework non-video video providers #628

Open
marcoroth opened this issue Feb 3, 2025 · 0 comments
Open

Rework non-video video providers #628

marcoroth opened this issue Feb 3, 2025 · 0 comments

Comments

@marcoroth
Copy link
Collaborator

marcoroth commented Feb 3, 2025

Currently we have a few hacky video providers which technically aren't really video providers:

  • scheduled
  • not_recorded
  • not_published
  • child
  • parent

I think most of them aren't really necessary and could be solved differently.

Now after we merged #616 would could use date to figure out if a date is in the future/past to determine the scheduled status. If the date is in the past and we don't have a recording it could automatically transition into not_published.

If a talk actually wasn't recorded we can set a recorded: false in the YAML file. If we know this upfront we could also set this field to let people know if the talk will get recorded or not. That would also help up from automatically transitioning from scheduled -> not_recorded.

I think we could even get rid of back video_provider and video_id from the talk itself, and have a recordings: Array in the YAML file which possibly gets mirrored in a Model/Database table.

  # videos.yml

  - title: "Keynote: Infinity and Beyond"
-   raw_title: 'RubyConf 2024 Keynote: Yukihiro "Matz" Matsumoto'
    speakers:
      - Yukihiro "Matz" Matsumoto
    event_name: RubyConf 2024
-   published_at: "2024-12-10"
    date: "2024-11-13"
    description: ""
-   video_provider: youtube
-   video_id: a4BJ9VUPWI8
+   recordings:
+    - title: 'RubyConf 2024 Keynote: Yukihiro "Matz" Matsumoto'
+      video_provider: youtube 
+      video_id: a4BJ9VUPWI8    
+      published_at: "2024-12-10"

With this approach, it's always additive and doens't need to be touched again to update the status of a talk. If we get a recording we can just add it to the recordings array, which can hold the raw_title, video_provider, and published_at, which is technically also where these fields belong.

Additionally, this would allow #579 to be realized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant