Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback for YouTube XL thumbnails #506

Open
marcoroth opened this issue Dec 10, 2024 · 1 comment
Open

Fallback for YouTube XL thumbnails #506

marcoroth opened this issue Dec 10, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@marcoroth
Copy link
Collaborator

marcoroth commented Dec 10, 2024

Some videos on YouTube don't have the XL thumbnail, which then leads to us rendering the generic YouTube thumbnail. I think it would be better if we could render the event fallback thumbnail instead.

Though, I'm not sure how we'd be able to detect that. Maybe with an API request?

For example:

CleanShot 2024-12-10 at 01 33 13

https://www.rubyvideo.dev/events/rubyconf-au-2024
https://www.rubyvideo.dev/talks/data-unleashed-a-developer-s-perspective-on-navigating-the-architecture-maze
https://www.rubyvideo.dev/talks/mapping-concepts-into-code

@marcoroth marcoroth added the enhancement New feature or request label Dec 10, 2024
@adrienpoly
Copy link
Owner

I made a quick test with onerror=this.remove() but it doesn't trigger an error. Looking at the network in dev tool, the fallback image is returned with a 404 status not sure how to detect that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants