Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort speaker talks by date #376

Open
nicogaldamez opened this issue Nov 5, 2024 · 4 comments
Open

Sort speaker talks by date #376

nicogaldamez opened this issue Nov 5, 2024 · 4 comments

Comments

@nicogaldamez
Copy link
Contributor

When I visit a speaker’s page, it’d be nice to see talks ordered by date with the most recent at the top and the oldest at the bottom.

Right now, this is what a user see:
image

@adrienpoly
Copy link
Owner

yes good idea

@marcoroth
Copy link
Collaborator

marcoroth commented Nov 5, 2024

The talks are actually ordered from most recent to oldest. In this case it's bad data for some of the conferences, since it's using the published_at field which is off by a few years.

@talks = @speaker.talks.with_essential_card_data.order(date: :desc)

@nicogaldamez
Copy link
Contributor Author

If it's just bad data, we can close this issue. What do you think?

@marcoroth
Copy link
Collaborator

marcoroth commented Nov 29, 2024

@nicogaldamez Technically yeah, unless we make sure to resolve all the bad data first 😅

At least we now have an actual idea how many talks still have bad data in the "Review Talk Dates" tab https://www.rubyvideo.dev/contributions

(for the contributions: I guess we should also have a way to link to a specially link to one of the pages)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants