Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Any plans of adding Web Notification API integration? #59

Open
jfrux opened this issue Jun 9, 2015 · 8 comments
Open

Feature: Any plans of adding Web Notification API integration? #59

jfrux opened this issue Jun 9, 2015 · 8 comments

Comments

@jfrux
Copy link

jfrux commented Jun 9, 2015

Just so that the browser is pinged if not in focus and stuff?
Just curious.

@simonexmachina
Copy link
Collaborator

I'd like to yes, but I've just started a new job and probably won't be using this for a while. So my feeling is that I won't be adding this, although I'd be open to helping someone with a PR.

@jfrux
Copy link
Author

jfrux commented Jun 10, 2015

Awesome, congratulations on the new job. Thank you for all you do for the community.
I'm working on a large project that may make use of this, if so, I might go ahead and just tie into the Web Notification API if available and I'll do a PR when I get it fairly stable.

@simonexmachina
Copy link
Collaborator

simonexmachina commented Jun 11, 2015 via email

@dukex
Copy link

dukex commented Oct 21, 2015

Hi guys, I'll love see this feature here. I'm using ember-notify in my app and I need Web Notification support. I have same questions about it:

  • When user has web notification support in the browser, the ember-notify will send duplicate notifications or only web notification?
  • Web notification has icon support, the ember-notify will create other API with icon params or always notification need support icon?

I can work on this pull request if is OK to @joshuairl

@simonexmachina
Copy link
Collaborator

Are we able to detect whether web notifications are enabled? If so then I think we should only display the web notification, not the DOM notification.

I think it's important to add icon support for both DOM and web notifications.

@ghost
Copy link

ghost commented Nov 18, 2015

@aexmachina @dukex web notifications appear to need permission first. This other library (notifications.js) has some logic that calls the native API methods to determine whether the web notifications are enabled:
https://github.com/MrSwitch/notification.js/blob/master/notification.js#L189

@lifeart
Copy link

lifeart commented Aug 29, 2016

@btecu
Copy link
Member

btecu commented May 28, 2019

@jfrux are you still interested in implementing native notifications?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants