Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transforms are not being mapped properly #61

Open
jhatwich opened this issue Sep 9, 2014 · 14 comments
Open

Transforms are not being mapped properly #61

jhatwich opened this issue Sep 9, 2014 · 14 comments

Comments

@jhatwich
Copy link
Contributor

jhatwich commented Sep 9, 2014

Needs test media and more information.

I am seeing problems with whack transforms when isolating a single layer. The test case I'm looking at is text on a path, but I think the problem at least includes other kinds of text if not all transforms in the isolated context.

@joebowden
Copy link

I'll add some test files.

@joebowden
Copy link

Here's a smoke file for shapes: http://adobe.ly/1wbWwMm

(warp, flip horizontal, & flip vertical currently generate correctly)

@joebowden
Copy link

Here's one with group transforms: http://adobe.ly/1nJgm9Q

(rotate & scale seem to generate svg correctly)

@joebowden
Copy link

Regression test file for QE: https://www.dropbox.com/s/7ax350b44e3s7ov/iOS7-Discover.psd?dl=0

From this issue: https://git.corp.adobe.com/edgecclayout/crema/issues/378 - Post.svg is not rendering - it has a transform matrix.

@jhatwich
Copy link
Contributor Author

Here is the one I was looking at where I noticed it first... (could be other issues at play too)...

https://drive.google.com/a/601t.com/file/d/0B1M3zV5eEym9OVlvdk5nNk1mdTg/edit?usp=sharing

@dirkschulze
Copy link
Contributor

Ok, it looks like the rawPath has the transformed path. It would of course be great if we can get the transform directly and we could preserve the shape type instead.

The current problem for shapes is just that we don't know if we have to use the rawPath or the shape directly. There doesn't seem to be a hint in the JSON file.

@dirkschulze
Copy link
Contributor

Here is the bug report for generator-core adobe-photoshop/generator-core#265

@jhatwich
Copy link
Contributor Author

For simple shapes it seems like we could work-around by writing the equivalent raw path and compare it to see if has been transformed... hackey, but seems like it might work. Worthwhile to look into this?

I'm thinking not since we would just end up with a raw path, not simple shape + transform like we really want.

@jhatwich
Copy link
Contributor Author

blocked on the generator-core bug. considering adding an errors.txt warning.

@imaderyc
Copy link

when fixed, please regress with testfile from https://git.corp.adobe.com/edgecclayout/crema/issues/403 (closed as duplicate with this bug)

@joebowden
Copy link

PS team logged the rotate case in Watson: https://watsonexp.corp.adobe.com/#bug=3822063

@joebowden
Copy link

Another issue from Seth Walker: https://git.corp.adobe.com/edgecclayout/crema/issues/594

@joebowden
Copy link

PS team logged another on transformed text: https://watsonexp.corp.adobe.com/#bug=3827889

@imaderyc
Copy link

another watson bug: 3849215

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants