Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate search #18

Open
adamghill opened this issue Jan 26, 2022 · 3 comments
Open

Investigate search #18

adamghill opened this issue Jan 26, 2022 · 3 comments

Comments

@adamghill
Copy link
Owner

Maybe via https://lunr.readthedocs.io/?

@Tobi-De
Copy link
Contributor

Tobi-De commented Sep 29, 2022

I'll work an implementation for this base on lunr.py and the django cache system for the backend logic.

But for the frontend (the search bar), I'm not so sure. I could write the javascript myself, but frankly, that sounds painful and my js is not that great. There's also django-unicorn and htmx that I've been thinking about. Django-unicorn might be too cumbersome for something so simple, htmx would be more appropriate but it's still another dependency to add to coltrane. I can work with any of the three (Including writing custom js for this) but what do you think is the better option? I'm also open to any other method for implementing this.

@adamghill
Copy link
Owner Author

We could also just have a search page that works for now (Python-only) and not try to implement a type-ahead or anything in JavaScript? I think in the future if we wanted anything fancy, I would probably advocate for htmx (even though Unicorn is my project, too 😆).

@Tobi-De
Copy link
Contributor

Tobi-De commented Sep 30, 2022

We could also just have a search page that works for now (Python-only) and not try to implement a type-ahead or anything in JavaScript? I think in the future if we wanted anything fancy, I would probably advocate for htmx (even though Unicorn is my project, too 😆).

Fine by me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants