Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@actions/http-client - unnecessary dependency upon undici #1560

Open
Jason3S opened this issue Oct 16, 2023 · 2 comments · May be fixed by #1561 or #1800
Open

@actions/http-client - unnecessary dependency upon undici #1560

Jason3S opened this issue Oct 16, 2023 · 2 comments · May be fixed by #1561 or #1800

Comments

@Jason3S
Copy link

Jason3S commented Oct 16, 2023 •
edited
Loading

When updating today, I noticed that size of my action bloated by 15k lines because undici was included as a dependency.

undici should have been in devDependencies, but was accidentally included in dependencies.

Originally posted by @Jason3S in #1547 (comment)

  /@actions/[email protected]:
    resolution: {integrity: sha512-3lBR9EDAY+iYIpTnTIXmWcNbX3T2kCkAEQGIQx4NVQ0575nk2k3GRZDTPQG+vVtS2izSLmINlxXf0uLtnrTP+g==}
    dependencies:
      '@actions/http-client': 2.2.0
      uuid: 8.3.2
    dev: false

  /@actions/[email protected]:
    resolution: {integrity: sha512-q+epW0trjVUUHboliPb4UF9g2msf+w61b32tAkFEwL/IwP0DQWgbCMM0Hbe3e3WXSKz5VcUXbzJQgy8Hkra/Lg==}
    dependencies:
      tunnel: 0.0.6
      undici: 5.26.3
    dev: false
@Jason3S Jason3S linked a pull request Oct 16, 2023 that will close this issue
Open
@jcesarmobile
Copy link

I don't think it can be a dev dependency since it's imported here

toolkit/packages/http-client/src/index.ts

Line 9 in fe3e7ce

import {ProxyAgent} from 'undici'

but the undici addition is breaking an action we have, not sure why

@Jason3S
Copy link
Author

Jason3S commented Oct 16, 2023

@jcesarmobile,

You are right. I'm still not seeing why it needs to be added to @actions/http-client.

@aminya aminya mentioned this issue Apr 1, 2024
Open
This was referenced Apr 6, 2024
Merged
Merged
@aminya aminya linked a pull request Aug 17, 2024 that will close this issue
Open
@glen-84 glen-84 mentioned this issue Oct 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@jcesarmobile @Jason3S